Error Identifier: div.rightNonNumeric
Every error reported by PHPStan has an error identifier. Here’s a list of all error identifiers. In PHPStan Pro you can see the error identifier next to each error and filter errors by their identifiers.
Code example #
<?php declare(strict_types = 1);
function doFoo(int $numerator, ?string $divisor): void
{
$result = $numerator / $divisor;
}
Why is it reported? #
This error is reported by phpstan/phpstan-strict-rules.
The right-hand side operand of a division (/) is not a numeric type. PHP’s division operator expects both operands to be numeric (int or float). Using a non-numeric type such as null, array, object, or a non-numeric string on the right side of a division will produce unexpected results or a TypeError in strict mode. Dividing by null is equivalent to dividing by zero, which produces a DivisionByZeroError.
How to fix it #
Ensure the right-hand operand is a numeric type by adding a type check or providing a default value:
<?php declare(strict_types = 1);
-function doFoo(int $numerator, ?string $divisor): void
+function doFoo(int $numerator, float $divisor): void
{
$result = $numerator / $divisor;
}
Or validate and convert the value before use:
<?php declare(strict_types = 1);
function doFoo(int $numerator, ?string $divisor): void
{
- $result = $numerator / $divisor;
+ if ($divisor !== null && is_numeric($divisor)) {
+ $result = $numerator / (float) $divisor;
+ }
}
How to ignore this error #
You can use the identifier div.rightNonNumeric to ignore this error using a comment:
// @phpstan-ignore div.rightNonNumeric
codeThatProducesTheError();
You can also use only the identifier key to ignore all errors of the same type in your configuration file in the ignoreErrors parameter:
parameters:
ignoreErrors:
-
identifier: div.rightNonNumeric
Rules that report this error #
- PHPStan\Rules\Operators\OperandsInArithmeticDivisionRule [1] phpstan/phpstan-strict-rules